TRD remove bug causing labels QC-941#1677
Merged
Merged
Conversation
Barthelemy
approved these changes
Mar 16, 2023
Contributor
Author
|
@Barthelemy shot for the formatting, for some reason my clang-format is not finding all. |
Barthelemy
added a commit
that referenced
this pull request
Mar 17, 2023
* TRD remove bug causing labels QC-941 * format --------- Co-authored-by: Barthelemy <barthelemy.von.haller@cern.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the labels from the layer plots of digits and tracklets.
I still cant replicate the problem causing the qc05 to fill the disk with logs. It is clearly coming from the labels of these graphs.
I can replicate the same error message but it would be on the epn and only after adding code to fill all bins with labels, unlike the commented out sections of the code in this PR.
A more permanent solution will come later.